Reactor classes in the same file with the same name, up to case differences, are prohibited #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a fix because we still have the problem that we consider reactor classes to have distinct names using a **case-sensitive** comparison, but we want to generate files corresponding to the reactor classes that will be compared **case-insensitively** on macOS. However, it does make our generated code "less wrong."
The file name of the fed-gen file should be specified in one place (DRY).
The problem here is that we use the uniqueID of the federate both before and after we transform it into separate programs. After we transform it, the name of the instance depends on the name of the main reactor, which might be different (indeed, it must be different in order for us to eliminate the possibility of name collisions with other parts of the program). So this is a bit of a hack, but I'm not sure what else to do.
It is bad that in order to make this change it is necessary to edit code in several places. But it isn't clear how to fix this because different parts of the code operate on the program at different stages in the compilation process, either before or after it has been split into many programs.
This is hacky. The problem is that the generated code does not have a federated reactor, but we do an AST transformation so that we can pretend that it is (I do not want to know why). So we end up running the code generator on a federated program, even though it is supposed to result on code for a single federate. So if the federate had its name prefixed once in the main run of the code generator, its name will be prefixed again in the nested run of the code generator.
|
I think this is ready for review. |
lhstrh
approved these changes
May 18, 2023
|
OK. I will choose to merge this now without testing the validation rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702.
The core issue in #1702 is that we consider reactor classes to have distinct names using a case-sensitive comparison, but we want to generate files corresponding to the reactor classes that will be compared case-insensitively on macOS.
We can't just mangle these file names because users might refer to them in their code.
Therefore, we should avoid creating reactor classes whose names are the same, up to case differences.