-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watchdogs #1605
Closed
Watchdogs #1605
Changes from 39 commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
718eaab
added func for watchdog name, created watchdog instance class
43bb491
made some progress on code generation
20531f0
more functions added for code generation
371385e
saving progress before pushing
86c369d
fixed grammar(added watchdog to 'varreformodetransition', removed wat…
15fc495
added watchdog grammar to reactor
6124cae
making sure updated before push
3798f3a
code generation steps (excluding mutex initialization) should be done…
bf4fd4c
generatewatchdogstruct in generateselfstruct
b87327f
save changes to watchdog
4f2fbb1
merge conflicts resolved
c8c569c
Added a few missing imports, but plenty compile errors remain
lhstrh 10cf741
saving before merging
63c624f
think fixed merge conflicts?
90d002f
at least it compiles now
45f0f9f
Merge remote-tracking branch 'origin/master' into watchdogs
4db9e0f
fixed build problems
f7b177e
tried, unsuccessfully, to fix variable grammar error
0487e8e
watchdog example test
ca78125
saving reactorc and changes to scopeprovider
c36cc80
saving changes to scope provider
94185e7
Fixed the scope provider
lhstrh 41e9487
Merge branch 'watchdogs' of github.com:lf-lang/lingua-franca into wat…
1726124
fixed trigger table
6994d46
saved?
29b7890
merged from main
43f8999
Merge master into watchdogs
lhstrh 3393c58
fixed compile issues
78405a3
fixing before merge
976b102
added casewatchdogs, still not fixed
0d31103
Also produce code for watchdogs in reactor definition
lhstrh 59b3737
Apply formatter to test
lhstrh ccb0b6a
Merge remote-tracking branch 'origin/master' into watchdogs
9d83f55
Fix submodule issues and remove files that should not be checked in
lhstrh ec8afa7
Remove spurious file
lhstrh da5b43a
Change order of submodules
lhstrh 9460c1a
Let version of reactor-cpp be the same as in master
lhstrh f1ae73f
Merge branch 'master' into watchdogs
lhstrh 043cfbc
Make submodule entries uniform
lhstrh bacf3af
Merge branch 'master' into watchdogs
lhstrh 774411b
Merge branch 'watchdogs' of github.com:lf-lang/lingua-franca into wat…
41c5430
Update org.lflang/src/org/lflang/ast/ToLf.java
Benichiwa 89abf74
Update org.lflang/src/org/lflang/ast/IsEqual.java
Benichiwa e4be4d5
Update org.lflang/src/org/lflang/ast/IsEqual.java
Benichiwa a81d25b
removed fixmes, updated grammar
f453bc4
Merge branch 'watchdogs' of github.com:lf-lang/lingua-franca into wat…
88dbef7
fixed ccpp test issue?
06b338e
Merge branch 'master' into watchdogs
lhstrh 5670e27
saving before pull again
0b27dd0
save before second pull
8df2efa
Merge branch 'watchdogs' of github.com:lf-lang/lingua-franca into wat…
c0ecf59
fixed
945bffe
added error reporting for unthreaded w watchdog
8228827
saving before checkout out klighd-workaround
2af0fa7
saving before klighd workaround
78b7fb5
merged reacotr-c
be2a4c9
some changes to code review
d87274f
Align lingua-franca/watchdogs with reactor-c/watchdogs
edwardalee aaa7368
Merged master in watchdogs
edwardalee e8a1b05
Deleted spurious empty files
edwardalee f9e9853
Merge remote-tracking branch 'origin/master' into watchdogs
edwardalee 998787a
Merge remote-tracking branch 'origin/watchdogs' into watchdogs-eal
edwardalee 534a003
Removed unused imports
edwardalee cb06dff
Group watchdog with action
edwardalee 302f690
Removed unused imports
edwardalee 7b05cd6
Removed non-substantive change
edwardalee 673a7fc
Removed unused or redundant imports
edwardalee 91086ad
Made this a real test
edwardalee c20e711
Made fields private and rearranged
edwardalee bb2a21d
Fixed hasWatchdogs, which was always returning true
edwardalee 6d33efc
Regularized function pointer
edwardalee 5e31d32
Align reactor-c
edwardalee 60cf911
merged changes, fixed inconsistencies, implemented watchdog stop
7fb877b
threading error working
58da147
merged master
8b3b3e3
saving before pull again
e1c7046
Merge branch 'watchdogs' of github.com:lf-lang/lingua-franca into wat…
6c22729
fixed generator issue
7b6ea7a
got everything to merge from watchdogs-eal branch
a4740c3
saving before continuing changes
1af9922
added watchdog to body of itself, started making changes to treat wat…
b5d6d58
create triggers save progress
Benichiwa 34f96e5
fixed watchdog test inconsistency? define watchdog trigger
f91883e
Merge branch 'master' of github.com:lf-lang/lingua-franca into watchdogs
a35208f
tried removing boolean from self-base_t struct, failed, everything wo…
5773b89
created check for runtime, and removed local one for each class
9e9aac7
saving changes before merging
755ff09
save before reattempting the merge
918c49a
hopefully succesfully resolved merge conflicts
b95830e
issues fixed w watchdog test, seems to be working as expected, not su…
3b8e0f7
removed fake python test
1f86008
updating reactor-c
1493800
fixed invocation of watchdog_stop in watchdog test
8aef4f7
fixed problem in recordWatchdogs (maybe temporary)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule reactor-c
updated
13 files
+0 −10 | .github/scripts/build-rti.sh | |
+0 −19 | .github/workflows/build-rti.yml | |
+0 −3 | .github/workflows/ci.yml | |
+0 −1 | core/federated/RTI/rti.c | |
+2 −0 | core/reactor.c | |
+59 −0 | core/reactor_common.c | |
+3 −0 | core/threaded/reactor_threaded.c | |
+5 −0 | include/api/api.h | |
+35 −0 | include/core/lf_types.h | |
+34 −0 | include/core/reactor.h | |
+5 −0 | include/core/reactor_common.h | |
+7 −0 | lib/schedule.c | |
+2 −0 | test/src_gen_stub.c |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,6 +91,7 @@ Reactor: | |
| (connections+=Connection) | ||
| (reactions+=Reaction) | ||
| (modes+=Mode) | ||
| (watchdogs+=Watchdog) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you move this up, right after the actions? |
||
)* '}'; | ||
|
||
|
||
|
@@ -176,7 +177,8 @@ Mode: | |
(actions+=Action) | | ||
(instantiations+=Instantiation) | | ||
(connections+=Connection) | | ||
(reactions+=Reaction) | ||
(reactions+=Reaction) | | ||
(watchdogs+=Watchdog) | ||
edwardalee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
)* '}'; | ||
|
||
// Action that has either a physical or logical origin. | ||
|
@@ -213,6 +215,11 @@ BuiltinTriggerRef: | |
|
||
Deadline: | ||
'deadline' '(' delay=Expression ')' code=Code; | ||
|
||
Watchdog: | ||
'watchdog' name=ID '(' timeout=Expression ')' | ||
('->' effects+=VarRefOrModeTransition (',' effects+=VarRefOrModeTransition)*)? | ||
code=Code; | ||
|
||
STP: | ||
'STP' '(' value=Expression ')' code=Code; | ||
|
@@ -274,7 +281,7 @@ TypedVariable: | |
; | ||
|
||
Variable: | ||
TypedVariable | Timer | Mode; | ||
TypedVariable | Timer | Mode | Watchdog; | ||
|
||
VarRef: | ||
variable=[Variable] | container=[Instantiation] '.' variable=[Variable] | ||
|
@@ -449,7 +456,7 @@ SignedFloat: | |
// Just escaping with \ is not a good idea because then every \ has to be escaped \\. | ||
// Perhaps the string EQUALS_BRACE could become '=}'? | ||
Code: | ||
//{Code} '{=' (tokens+=Token)* '=}' | ||
// {Code} '{=' (tokens+=Token)* '=}' | ||
{Code} '{=' body=Body '=}' | ||
; | ||
|
||
|
@@ -496,7 +503,7 @@ Token: | |
'mutable' | 'input' | 'output' | 'timer' | 'action' | 'reaction' | | ||
'startup' | 'shutdown' | 'after' | 'deadline' | 'mutation' | 'preamble' | | ||
'new' | 'federated' | 'at' | 'as' | 'from' | 'widthof' | 'const' | 'method' | | ||
'interleaved' | 'mode' | 'initial' | 'reset' | 'history' | | ||
'interleaved' | 'mode' | 'initial' | 'reset' | 'history' | 'watchdog' | | ||
// Other terminals | ||
NEGINT | TRUE | FALSE | | ||
// Action origins | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the grammar, watchdogs don't have a value or type, so there appears to be nothing actionable here. Remove?