Arduino MBED RTOS Support #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
reviewed
Feb 12, 2023
| @@ -52,7 +52,7 @@ private String generateMainFunction() { | |||
| "// Arduino setup() and loop() functions", | |||
| "void setup() {", | |||
| "\tSerial.begin(" + targetConfig.platformOptions.baudRate + ");", | |||
| "\tlf_register_print_function(&_lf_arduino_print_message_function, LOG_LEVEL);", | |||
| "\tlf_register_print_function(&_lf_arduino_print_message_function, 0);", | |||
lhstrh
reviewed
Feb 12, 2023
| @@ -394,20 +394,22 @@ private static boolean copyDirectoryFromJar(JarURLConnection connection, final P | |||
| * @param dir The folder to search for folders and files to delete. | |||
| * @throws IOException If the given folder and unneeded files cannot be deleted. | |||
| */ | |||
| public static void arduinoDeleteHelper(Path dir) throws IOException { | |||
| public static void arduinoDeleteHelper(Path dir, Boolean isThreading) throws IOException { | |||
There was a problem hiding this comment.
Suggested change
| public static void arduinoDeleteHelper(Path dir, Boolean isThreading) throws IOException { | |
| public static void arduinoDeleteHelper(Path dir, boolean isThreading) throws IOException { |
There was a problem hiding this comment.
Maybe a better name of the variable would be threadingOn?
| @@ -611,7 +611,7 @@ private String generateCodeToInitializeFederate(FederateInstance federate, Linke | |||
| code.pr(String.join("\n", | |||
| "// Initialize the socket mutex", | |||
| "lf_mutex_init(&outbound_socket_mutex);", | |||
| "lf_cond_init(&port_status_changed);" | |||
| "lf_cond_init(&port_status_changed, &outbound_socket_mutex);" | |||
There was a problem hiding this comment.
I don't know what's going on here, but that's probably because I haven't yet checked out your reactor-c PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBED RTOS requires the use of threading as a means of supporting physical actions on Arduino. This pull request adds full support for MBED boards using C-Style APIs to interface our reactor-c library to MBED RTOS's C++ infrastructure (Threads, ConditionVariables, and Mutexes)