Tracing tools Makefile fixed #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Shouldn't the trace tools for C rather be located in the reactor-c repository? Or maybe in its own repo? They are only useful for the C target and also only really interesting for us developers (at least at the moment). Also it seems pretty weird to me, to have include paths pointing into our LF source tree. Even if we decide to keep it here, the build should be tested as part of CI so that it does not break again.
Note that the tools for C++ tracing are currently also located in the reactor-cpp repo. Also
edwardalee
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Makefile for building the trace tools.