Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of paths not URIs in line-directives #1412

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Use of paths not URIs in line-directives #1412

merged 2 commits into from
Oct 13, 2022

Conversation

erlingrj
Copy link
Collaborator

Addressing #1407

edwardalee
edwardalee approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this correctly report errors on the right line in Epoch?

@cmnrd cmnrd requested a review from petervdonovan October 13, 2022 14:52
@cmnrd
Copy link
Collaborator

cmnrd commented Oct 13, 2022

Also I am wondering how this affects error reporting via the LSP and on the command line in lfc. Tagging @petervdonovan

@erlingrj
Copy link
Collaborator Author

I am away for a week. I'm not sure how this affects Epoch or LSP.

@petervdonovan
Update compiler message regex.
0dce38f 
Thanks to @cmnrd and edwardalee for pointing out that this was needed.

Lines are correctly adjusted in VS Code now. Note that this could have
been merged without this fix because I chose to specifically exclude
C from the LSP tests out of reluctance to maintain the #line
directive mechanism; see lf-lang/vscode-lingua-franca#84
petervdonovan
petervdonovan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this now. Thanks Erling!

@petervdonovan petervdonovan linked an issue Oct 13, 2022 that may be closed by this pull request
Line directives+GDB not working properly on WSL #1407
Closed
@petervdonovan petervdonovan merged commit ba4ff64 into master Oct 13, 2022
@petervdonovan petervdonovan deleted the fix-line-directives branch October 13, 2022 19:22
@lhstrh lhstrh added the bugfix label Jan 26, 2023
@lhstrh lhstrh changed the title Use path, not URI in line-directives (#1407) Use of paths not URIs in line-directives Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@petervdonovan petervdonovan petervdonovan approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line directives+GDB not working properly on WSL
5 participants
@erlingrj @cmnrd @edwardalee @petervdonovan @lhstrh