-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augmented support for Arduino #1384
Conversation
@lhstrh Anirudh would like to finish this line of work before applying the changes related to 64bit and nanoseconds to the Arduino port. I think this is reasonable, but I also think it is possible to apply the other changes first. I am mentioning this because there have very recently been discussions on what is really the job of LFC and how should we extend support to multiple embedded targets. This PR sort of represents one possible path where we tightly integrate support for embedded targets into LFC and try to have "end-to-end" build and flash through LFC. I do think that we can merge this in even before making a decision on how to support embedded targets. In the worst case we would have to do refactoring later. I am pushing a bit on this because it should be done before we can merge lock_time branch into reactor-c main so that we can start working on supporting more embedded targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I am afraid that the approach of hard coding all platforms in an enum will require too much maintenance, but I'm not sure we have a viable alternative. These are certainly improvements over what's currently in master
, so let's merge.
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
Fix bug in Windows diagnostic reporting.
This PR will address the following issues dealing with running Arduino on LF