Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New target property for specifying additional ROS dependencies #1355

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Sep 6, 2022

This change adds the ros2-dependencies target property, which allows to specify additional ROS2 packages that the LF program depends on. This is analogous to the cargo-depencies property for Rust. This mechanism is particularly useful for defining custom ROS2 types using IDL in a separate package and making those available in the LF program. Colcon will automatically locate the additional dependencies and make sure that all relevant headers are available and libraries are linked correctly.

@cmnrd cmnrd added enhancement Enhancement of existing feature cpp Related to C++ target labels Sep 6, 2022
@cmnrd cmnrd requested a review from Rodario September 6, 2022 14:01
Copy link
Collaborator

@Rodario Rodario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with a pub/sub setup that uses a custom ROS2 message package and it works.
It should be noted that LF does not build your additional packages for you. That needs to be done prior to compiling with lfc.

@cmnrd
Copy link
Collaborator Author

cmnrd commented Sep 7, 2022

What's the goal of this PR? A description would be nice :-)

I added more details to the description

@cmnrd cmnrd merged commit 5665cbf into master Sep 8, 2022
@cmnrd cmnrd deleted the ros2-dependencies branch September 8, 2022 08:16
cmnrd added a commit to lf-lang/playground-lingua-franca that referenced this pull request Sep 9, 2022
@lhstrh lhstrh changed the title Add target property for specifying additional ROS dependencies New target property for specifying additional ROS dependencies Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ target enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants