Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized access to sparse multiports in the C++ target #1312

Merged
merged 29 commits into from
Oct 7, 2022
Merged

Optimized access to sparse multiports in the C++ target #1312

merged 29 commits into from
Oct 7, 2022

Conversation

tanneberger
Copy link
Member

@tanneberger tanneberger commented Aug 1, 2022 •
edited
Loading

Multiport Optimization

Ports contained inside a multiport are now smart and will help the multiport to keep track of all the present ports.
This changes will increase performance for sparse multiports e.g. Big Benchmark. Previously a std::vector was used
to store ports this is now replaced by reactor::Multiport class.

This changes are related to:

@tanneberger tanneberger added the enhancement Enhancement of existing feature label Aug 1, 2022
@tanneberger tanneberger requested a review from cmnrd August 1, 2022 11:37
@tanneberger tanneberger self-assigned this Aug 1, 2022
@tanneberger tanneberger marked this pull request as ready for review August 1, 2022 11:43
cmnrd
cmnrd reviewed Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good to me (I only had one question). But we should wait with merging this until lf-lang/reactor-cpp#24 is merged.

@tanneberger tanneberger requested a review from cmnrd September 9, 2022 08:43
@tanneberger tanneberger mentioned this pull request Sep 9, 2022
Merged
cmnrd
cmnrd reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I added a few nitpicks. Also it seems like you changed the refs of other submodules then reactor-cpp, which should not be needed.

lib/scripts/launch.sh Outdated Show resolved Hide resolved
test/Cpp/src/multiport/BankSelfBroadcast.lf Show resolved Hide resolved
test/Cpp/src/multiport/CallbackMultiport.lf Outdated Show resolved Hide resolved
@cmnrd
Copy link
Collaborator

cmnrd commented Sep 9, 2022

Could you also update the PR description?

@tanneberger tanneberger mentioned this pull request Sep 13, 2022
Merged
@cmnrd cmnrd added the cpp Related to C++ target label Sep 15, 2022
@tanneberger tanneberger requested a review from cmnrd September 20, 2022 13:50
@cmnrd cmnrd changed the title Multiport Optimization Optimize access to sparse multiports in the C++ target Oct 6, 2022
cmnrd
cmnrd approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that we can finally merge this!

@cmnrd cmnrd merged commit 022d713 into lf-lang:master Oct 7, 2022
@lhstrh lhstrh changed the title Optimize access to sparse multiports in the C++ target Optimized access to sparse multiports in the C++ target Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd approved these changes

Assignees

@tanneberger tanneberger

Labels
cpp Related to C++ target enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanneberger @cmnrd