Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icons for reactors in diagrams #1300

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Custom icons for reactors in diagrams #1300

merged 6 commits into from
Aug 30, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Jul 20, 2022

Adds support for using the new attribute notation for annotating reactors with an icon.

@a-sr a-sr requested a review from lhstrh July 20, 2022 14:43
@a-sr a-sr added diagrams Problems with diagram synthesis enhancement Enhancement of existing feature labels Jul 20, 2022
@lhstrh lhstrh added feature New feature and removed enhancement Enhancement of existing feature labels Jul 21, 2022
@lhstrh lhstrh changed the title Add icon attribute Custom icons for reactors in diagrams Jul 21, 2022
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it makes me wonder allowable image formats/extensions. We should probably instate some checks to ensure that images are viable and can be displayed correctly.

@a-sr
Copy link
Collaborator Author

a-sr commented Aug 18, 2022

Ok, I improved the error reporting and added validation rule to issue warnings for bad icon paths.

@lhstrh
Copy link
Member

lhstrh commented Aug 19, 2022

Very cool!

@lhstrh lhstrh merged commit 71d832a into master Aug 30, 2022
@lhstrh lhstrh deleted the icon-attribute branch August 30, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Problems with diagram synthesis feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants