Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed +nightly command for cargo #1295

Closed
wants to merge 2 commits into from

Conversation

tanneberger
Copy link
Member

@tanneberger tanneberger commented Jul 14, 2022

Tiny pull request so the rust code is built with:

cargo build --release

instead of

cargo +nightly build --release

The problem is that the +nightly argument only exists in cargo from rustup. So standard the "standard" cargo will fail.

       error: no such subcommand: `+nightly`
       --> (unknown file):null:1 - cargo failed with error code 101 and reported the following error
       (error: no such subcommand: `+nightly`
       
       
       lfc: fatal error: Aborting due to previous error

=> the cargo in my env is nightly

@tanneberger tanneberger added build system rust Related to the Rust target labels Jul 14, 2022
@tanneberger tanneberger self-assigned this Jul 14, 2022
@tanneberger tanneberger requested a review from oowekyala July 14, 2022 08:24
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we already have #1218. Maybe you can sync with @jhaye on this matter ;)

@cmnrd
Copy link
Collaborator

cmnrd commented Jul 29, 2022

Closing this since we merged #1218

@cmnrd cmnrd closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system rust Related to the Rust target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants