Platform target property #1246
Platform target property #1246
Conversation
| @@ -0,0 +1,12 @@ | |||
| /** | |||
| * Test that the cross-compile capability works as expected. | |||
There was a problem hiding this comment.
What does this test, exactly? Isn't this expected to only work on macOS?
There was a problem hiding this comment.
No, I'm hoping that this works on Linux too. The target tests for C only run on Mac and Linux.
There was a problem hiding this comment.
The target tests for C only run on Mac and Linux.
That's exactly why I'm asking. I would expect compilation to work, but the produced executable to not work on Linux or Windows... If not, when what does the target property do at all?
There was a problem hiding this comment.
As I commented below, there is a lot more to cross-compiling than just setting the platform. In that sense, the platform target property doesn't enable true cross-compiling on its own as implemented. Essentially, all it does right now is to select which one of the platform files we link against. The platform support files for Mac should work on Linux too, hence why I think the test will pass.
To enable true cross-compiling, we need to add additional missing pieces (marked with ???):
# the name of the target operating system
# set(CMAKE_SYSTEM_NAME Windows) # This is set by the platform target property
# which compilers to use for C and C++
set(CMAKE_C_COMPILER i586-mingw32msvc-gcc) # ???
set(CMAKE_CXX_COMPILER i586-mingw32msvc-g++) # ???
# where is the target environment located
set(CMAKE_FIND_ROOT_PATH /usr/i586-mingw32msvc
/home/alex/mingw-install) # ???
# adjust the default behavior of the FIND_XXX() commands:
# search programs in the host environment
set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER) # ???
# search headers and libraries in the target environment
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY) # ???
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY) # ???There was a problem hiding this comment.
Got it. What do we have to do to support a CMAKE_SYSTEM_NAME that is not a popular OS but something like Arduino or FlexPRET? I did find https://github.com/arduino-cmake/Arduino-CMake-NG.
There was a problem hiding this comment.
This is very promising. I think if we want to use this, from the looks of the example in the README of that repo, we need to generate a custom CMakeLists.txt entirely for Arduino since executables are created by calling a add_arduino_executable method, which is a custom CMake method.
|
It should be noted that the |
I'm not sure either. I'm 51% sure it works on Linux too :). Let's wait for the CI to finish. |
|
Looks like this is a go? |
This is based on the work started by @sberkun in #1118.