Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging cleanups for VS Code #1174

Merged
merged 2 commits into from
May 17, 2022
Merged

Logging cleanups for VS Code #1174

merged 2 commits into from
May 17, 2022

Conversation

petervdonovan
Copy link
Collaborator

@petervdonovan petervdonovan commented May 16, 2022 •
edited
Loading

This PR improves the textual output that is emitted by the language server. It should be merged before the corresponding PR here.

@petervdonovan petervdonovan mentioned this pull request May 16, 2022
Merged
lhstrh
lhstrh approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Bizarre that VS Code ignores standard out...

@petervdonovan petervdonovan merged commit 90b09af into master May 17, 2022
@petervdonovan petervdonovan deleted the logging-cleanup2 branch May 17, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petervdonovan @lhstrh