Support inline code arguments on main reactor for Rust target #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a test, but not sure if it's automatically added to the bulk test run. |
cmnrd
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously inline arguments for the main reactor weren't handled in a way that was appropriate for clap, the CLI library used for Rust reactor programs.
Basically, it couldn't handle arguments like this:
max_value: u64({= 1 << 60 =}).This PR upgrades to a stable version of clap and handles inline arguments correctly. This depends on #1098, so that should be merged first.
Ref: lf-lang/benchmarks-lingua-franca#5