Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network sender reaction multiport #1061

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

Soroosh129
Copy link
Contributor

This fixes an issue related to the way network sender reactions are triggered when their trigger is a multiport output from a federate or a bank of federates.

In this fix, a check is added to make sure a given port is present before the body of the network sender reaction reads it.

@Soroosh129 Soroosh129 requested a review from edwardalee March 26, 2022 15:14
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge.

@edwardalee edwardalee merged commit a468a6e into master Mar 26, 2022
@Soroosh129 Soroosh129 deleted the fix-network-sender-reaction-multiport branch March 26, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants