Improved Support for Imported Reactors in Diagrams #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alt+Click on a diagram element will now jump to the associated code section even if it is located in a different editor. This implementation only affects the Epoch IDE.
Selected diagram elements that are associated with code sections outside the current editor now refer to their import.
edwardalee
approved these changes
Mar 21, 2022
lhstrh
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A normal selection of diagram elements that originate from code outside the current editor (imported reactors), will now highlight the respective import instead of nothing.
If the Alt key is down during selection of such diagram elements, the active editor will change to the one containing the code. This will also cause the diagram view to update its content this reflect the model of the new active editor.
Closes #889
Since this is a UI specific feature, this current implementation only affects the Epoch IDE. The LF VSC extension requires a separate implementation which I am not familiar with.