Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all Xtend dependencies #1051

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Removed all Xtend dependencies #1051

merged 4 commits into from
Mar 18, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Mar 17, 2022

Since the last xtend file has been ported to java in #1049, all Xtend dependencies can be removed.

@lhstrh lhstrh changed the title Remove xtend dependecies Removed all Xtend dependencies Mar 17, 2022
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. There are two things I believe might not be addressed by this:

  • I believe that the Oomph config added empty xtend-gen directories somewhere, but this might have already gone away in the PR submitted by @soerendomroes; and
  • XtendFormatterEclipse.xml is no longer needed and should also be removed.

@housengw housengw merged commit 0766c41 into master Mar 18, 2022
@housengw housengw deleted the remove-xtend-dependencies branch March 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants