Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all tabs with spaces in the org.lflang.diagrams package #1047

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Mar 16, 2022

As suggested in #1040 this eliminates the use of tabs in the diagrams package.

@a-sr a-sr changed the title Replaces all Tabs with Spaces in the Diagrams Package Replace all Tabs with Spaces in the Diagrams Package Mar 16, 2022
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but there appears to be a persistent Oomph-related build problem that I don't quite understand.

@lhstrh
Copy link
Member

lhstrh commented Mar 16, 2022

This problem now also breaks master:

Error:  Failed to resolve target definition file:/home/runner/work/lingua-franca/lingua-franca/org.lflang.targetplatform/org.lflang.targetplatform.target: Could not find "org.eclipse.xpand.feature.group/0.0.0" in the repositories of the current location -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
[INFO] Scanning for projects...
[INFO] Computing target platform for MavenProject: org.lflang:org.lflang:0.1.0-SNAPSHOT @ /home/runner/work/lingua-franca/lingua-franca/org.lflang/pom.xml
[INFO] Resolving target definition file:/home/runner/work/lingua-franca/lingua-franca/org.lflang.targetplatform/org.lflang.targetplatform.target for environments=[win32/win32/x86_64, linux/gtk/x86_64, macosx/cocoa/x86_64], include source mode=honor, execution environment=StandardEEResolutionHints [executionEnvironment=OSGi profile 'JavaSE-11' { source level: 11, target level: 11}], remote p2 repository options=org.eclipse.tycho.p2.remote.RemoteAgent@632dc41...
Error:  Failed to resolve target definition file:/home/runner/work/lingua-franca/lingua-franca/org.lflang.targetplatform/org.lflang.targetplatform.target: Could not find "org.eclipse.xpand.feature.group/0.0.0" in the repositories of the current location -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
Error: Process completed with exit code 1.

@lhstrh lhstrh merged commit 9da3d0f into master Mar 17, 2022
@lhstrh lhstrh deleted the diagrams branch March 17, 2022 18:45
@lhstrh lhstrh changed the title Replace all Tabs with Spaces in the Diagrams Package Replace all tabs with spaces in the org.lflang.diagrams package Mar 17, 2022
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants