Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial refactoring of CGenerator.xtend #1045

Merged
merged 18 commits into from
Mar 16, 2022
Merged

Partial refactoring of CGenerator.xtend #1045

merged 18 commits into from
Mar 16, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Mar 16, 2022 •
edited by lhstrh
Loading

This PR constitutes another part of the effort to port CGenerator.xtend to java.
After this, I think I will complete the port.
See #838

lhstrh
lhstrh reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Some newly created functions still need JavaDoc, but this being a draft, I'm guessing you're aware of that :-)

@housengw housengw marked this pull request as ready for review March 16, 2022 05:38
@housengw housengw requested a review from lhstrh March 16, 2022 05:39
lhstrh
lhstrh approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@lhstrh lhstrh merged commit fb607d9 into master Mar 16, 2022
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh changed the title refactor CGenerator.xtend Partial refactoring of CGenerator.xtend Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@housengw @lhstrh