Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in tracing util. #1043

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix errors in tracing util. #1043

merged 1 commit into from
Mar 15, 2022

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Mar 15, 2022

No description provided.

Soroosh129
Soroosh129 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for fixing this.
This shows that we should add tests for these utilities.

@hokeun hokeun merged commit 74e2359 into master Mar 15, 2022
@Soroosh129 Soroosh129 deleted the fix-tracing-util branch March 15, 2022 13:30
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soroosh129 Soroosh129 Soroosh129 approved these changes

@edwardalee edwardalee Awaiting requested review from edwardalee

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokeun @Soroosh129 @lhstrh