Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly recognize network message actions in TypeScript generator #1042

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Properly recognize network message actions in TypeScript generator #1042

merged 2 commits into from
Mar 15, 2022

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Mar 15, 2022

No description provided.

@hokeun
Fix networkMessage action handling in TypeScript code generation, by …
18cb8c1 
…considering action names prefixed with "networkMessage".
@hokeun hokeun requested a review from lhstrh March 15, 2022 10:15
@hokeun
Copy link
Member Author

hokeun commented Mar 15, 2022

You don’t have to check by name. We keep track of all network actions:

lingua-franca/org.lflang/src/org/lflang/federated/FederateInstance.java

Line 183 in 6fbd57f

public List<Action> networkMessageActions = new ArrayList<>();

Thanks for the great comment! Fixed this in 3719935.

@hokeun hokeun requested a review from Soroosh129 March 15, 2022 12:58
Soroosh129
Soroosh129 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Soroosh129 Soroosh129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hokeun hokeun merged commit 76597f1 into master Mar 15, 2022
@hokeun
Copy link
Member Author

hokeun commented Mar 15, 2022

Looks good to me!

Thanks!!

@hokeun hokeun deleted the ts-federate branch March 15, 2022 14:08
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh changed the title Fix networkMessage action handling in TypeScript code generation, by considering action names prefixed with "networkMessage". Properly recognize network message actions in TypeScript generator Mar 17, 2022
@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soroosh129 Soroosh129 Soroosh129 approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokeun @Soroosh129 @lhstrh