Benchmark updates #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents get_physical_time from being invoked in the wait_until function in reactor_threaded.c. The overhead of that call to get_physical_time appears to be as much as 10% of total cycles in benchmarks like PingPong whose execution times are dominated by runtime overhead.
At Berkeley, CS61C students are taught not to declare counters in "for" loops because it used to be UB/forbidden in older versions of C. The best solution to this is probably not to use a global variable (!!!!!!!) as a counter (!!!!!), especially in a program with parallelism. This change also gives the program a more explicit error message if the output is incorrect.
I take full responsibility for this one. When I changed the way output was parsed, print statements that lacked terminating newlines interfered with the timing reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another round of small adjustments to the benchmarks. This PR is submitted now at @cmnrd's suggestion to address #1058.