-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for eden_version input in test workflow #954
Add support for eden_version input in test workflow #954
Conversation
@uncleDecart this is a WIP, I want to run the tests and see if this implementation works. For the cause of this change see the discussion with @eriknordmark here |
@uncleDecart you are right! But I assume we still haven't found a solution how to backport the fix to 0.9.2 - this is why the jobs are failing. How about creating a branch from 0.9.2, perhaps calling it something similar, backporting the commit with the fix to that branch and then referencing the branch in EVE's 11.0-stable |
make sense |
One yetus failure: |
When the workflow is triggered from the outside, action/checkout defaults to checking out the latest master which is not always desired. For better compatibility with older EVE release the user should be able to specify the version of eden to be used in the test workflow. If no version is specified, the workflow should resert to the default behavior. Signed-off-by: Paul Gaiduk <paulg@zededa.com>
335ef53
to
2d3a0fc
Compare
@uncleDecart it looks like the solution from here doesn't work. See latest comments on the issue and our own test results Should we use the one proposed in the current PR instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good to me, but right now we can't see if it's working or not. I'll create small example to check it out and let you know |
I think we can leave the checkout version as it is - we still use v3 for all the other workflows for example and I don't see any new features in the latest release that we would need. |
Since node16 that is used by action/checkout v3 has reached EOL, we upgrade the version to the latest 4.1.1. Signed-off-by: Paul Gaiduk <paulg@zededa.com>
@uncleDecart you are right! The EOL slipped my mind. Updated to 4.1.1 for whole Eden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait for tests and then merge
When the workflow is triggered from the outside, action/checkout defaults to checking out the latest master which is not always desired. For better compatibility with older EVE release the user should be able to specify the version of eden to be used in the test workflow. If no version is specified, the workflow should resert to the default behavior.