Port.command changes to UDP driver #42
Comments
|
Erlang bug tracker has indicated this as "not a bug" because the interface was internal https://bugs.erlang.org/browse/ERL-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803#comment-14803 Statix will need to conditionally support the new driver format, or use gen_udp. I'd be happy to PR a |
|
I've created a fork over at https://github.com/bleacherreport/statix that has a couple of commits merged in that we use. I also have a branch that fixes OTP-21.3.8.4 here: https://github.com/bleacherreport/statix/tree/otp-21.3.8.4-support I think it works, but it probably needs some cleanup and testing. If anyone is running into this issue with OTP-21.3.8.4 and wants to give it a try that would be appreciated. |
This is needed for compatibility with newer ERTS releases lexmag/statix#42. We should also look into maybe using bleacherreport's fork as I'm not a fan of calling Port.command directly instead of using `:gen_udp.send`
|
@lexmag Do you feel confident this library will end up solving this issue? Or should I be looking elsewhere? |
|
Beyond the Erlang/OTP versions affected by this bug reported by @sb8244, I was just bitten by this on Erlang/OTP 21.3.8.6: https://github.com/erlang/otp/blob/OTP-21.3.8.6/erts/preloaded/src/prim_inet.erl#L568 Upgrading to v1.2.1 fixed it, so I guess this issue could be closed @lexmag? |
This is needed for compatibility with newer ERTS releases lexmag/statix#42. We should also look into maybe using bleacherreport's fork as I'm not a fan of calling Port.command directly instead of using `:gen_udp.send`
|
It is happening again with OTP26: erlang/otp#7130 Any plans to move to |
It looks like the UDP driver has changed in Erlang 21.3.8.4 which causes all Statix calls to fail. It appears that changing
Port.command:gen_udp.sendwould fix this issue. Is there a reason to not use:gen_udp.sendhere? One benefit of:gen_udp.sendis that the packet creation becomes a bit simpler.21.3.8.3 - https://github.com/erlang/otp/blob/OTP-21.3.8.3/erts/preloaded/src/prim_inet.erl#L561
21.3.8.4 - https://github.com/erlang/otp/blob/OTP-21.3.8.4/erts/preloaded/src/prim_inet.erl#L568
The text was updated successfully, but these errors were encountered: