Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA: Add feature flag DisableLegacyLimitWrites #7728

Merged
merged 2 commits into from
Sep 30, 2024
Merged

SA: Add feature flag DisableLegacyLimitWrites #7728

merged 2 commits into from
Sep 30, 2024

Conversation

beautifulentropy
Copy link
Member

No description provided.

@beautifulentropy beautifulentropy force-pushed the feature-disable-rl-writes branch from da149ae to f2a5ccd Compare September 27, 2024 22:17
@beautifulentropy beautifulentropy force-pushed the feature-disable-rl-writes branch from d634d6e to aba2c28 Compare September 27, 2024 22:52
@beautifulentropy beautifulentropy marked this pull request as ready for review September 27, 2024 22:53
@beautifulentropy beautifulentropy requested a review from a team as a code owner September 27, 2024 22:53
@github-actions GitHub Actions
Copy link
Contributor

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@github-actions GitHub Actions
Copy link
Contributor

@beautifulentropy, this PR adds one or more new feature flags: DisableLegacyLimitWrites. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document.

Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:".

aarongable
aarongable approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo filing an SRE ticket.

@beautifulentropy
Copy link
Member Author

beautifulentropy commented Sep 30, 2024 •
edited
Loading

LGTM modulo filing an SRE ticket.

Filed IN-10722.

@beautifulentropy beautifulentropy merged commit 2fa9fbc into main Sep 30, 2024
17 checks passed
@beautifulentropy beautifulentropy deleted the feature-disable-rl-writes branch September 30, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @jsha @aarongable