Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from square/go-jose to go-jose/go-jose #6573

Closed
aarongable opened this issue Jan 10, 2023 · 3 comments
Closed

Switch from square/go-jose to go-jose/go-jose #6573

aarongable opened this issue Jan 10, 2023 · 3 comments
Assignees
@pgporada
Milestone
Sprint 2023-01-17

Comments

@aarongable
Copy link
Contributor

The square repository will be archived next month. This may require some API updates, as we move from v2 of the square repo to v3 of the new repo.
@aarongable aarongable added this to the Sprint 2023-01-10 milestone Jan 10, 2023
@mcpherrinm
Copy link
Contributor

Note that v2 is available in go-jose/go-jose too, so simply changing the import paths is a good start. But switching to v3 should probably happen.

@aarongable
Copy link
Contributor Author

v2 is available as a branch, and that branch doesn't have a tag for the v2.6.0 that we're currently pinned to, so simply staying on v2 isn't quite as easy as it might seem. Agreed that we should simply switch to v3 unless doing so requires ripping out inordinate amounts of code.

@pgporada pgporada mentioned this issue Jan 11, 2023
Closed
@aarongable
Copy link
Contributor Author

Due to some issues we've filed against the v3 branch of the go-jose/go-jose repo, we're going to instead (for now) switch repos but keep the version the same. Phil will check to make sure that all commits in the current version we use exist in that repo, and then one of the new repo's maintainers will tag a new release on the v2 branch.

@pgporada pgporada mentioned this issue Jan 26, 2023
Merged
jsha pushed a commit that referenced this issue Jan 26, 2023
@pgporada
Upgrade go-jose/go-jose from v2.6.0 to v2.6.1 (#6614)
f7912b1 
From the go-jose/go-jose v2.6.1 merge commit:

> The square/go-jose repo had one commit "Fix EC thumbprint template"
> which existed on the v2.6.0 tag but not on the v2 branch. This means
that
> it was missed in the recent PR which merged square's v2 branch into
this
> repository's v2 branch. This also means that the current v2.6.0 tag in
this
> repo points to a commit which is not on any branch in this repo.

Now that Aaron has pushed a go-jose/go-jose v2.6.1 tag, we can upgrade
to that and remove the indirect reference to square/go-jose v2.6.0.

Related to #6573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgporada pgporada

Labels
None yet
Projects
None yet
Milestone
Sprint 2023-01-17
Development

Successfully merging a pull request may close this issue.

Upgrade from go/go-jose.v2 to go-jose/go-jose.v3
3 participants
@mcpherrinm @pgporada @aarongable