Skip to content

Commit

Permalink
VA: Fix performRemoteValidation goroutine leak (#7727)
Browse files Browse the repository at this point in the history
PerformValidation goroutines write to a buffered results channel to
prevent blocking.
  • Loading branch information
beautifulentropy authored Sep 30, 2024
1 parent d850e63 commit ab69b72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion va/va.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func (va *ValidationAuthorityImpl) performRemoteValidation(
err error
}

results := make(chan *rvaResult)
results := make(chan *rvaResult, len(va.remoteVAs))

for _, i := range rand.Perm(len(va.remoteVAs)) {
remoteVA := va.remoteVAs[i]
Expand Down

0 comments on commit ab69b72

Please sign in to comment.