tec: Upgrade to Webpack 4 #360

marienfressinaud · 2019-05-05T20:25:44Z

Changes proposed in this pull request:

I spent a bit more time to update to Webpack 4. I hope it's finished
now...

References:

Pull request checklist:

branch is rebased on master *
proper commit messages *
proper coding style *
code is properly tested
document API changes both in technical documentation and changelog (optional)
document migration notes (optional)
reviewer assigned (@marienfressinaud)

* Additional information in the documentation.

houndci-bot · 2019-05-05T20:25:48Z

client/build/webpack.prod.conf.js

@@ -7,7 +7,7 @@ const merge = require('webpack-merge')
 const baseWebpackConfig = require('./webpack.base.conf')
 const CopyWebpackPlugin = require('copy-webpack-plugin')
 const HtmlWebpackPlugin = require('html-webpack-plugin')
-const ExtractTextPlugin = require('extract-text-webpack-plugin')
+const MiniCssExtractPlugin = require('mini-css-extract-plugin')


'require' is not defined no-undef

houndci-bot · 2019-05-05T20:25:49Z

client/build/webpack.base.conf.js

@@ -3,6 +3,7 @@ const path = require('path')
 const utils = require('./utils')
 const config = require('../config')
 const vueLoaderConfig = require('./vue-loader.conf')
+const { VueLoaderPlugin } = require('vue-loader')


'require' is not defined no-undef

houndci-bot · 2019-05-05T20:25:49Z

client/build/utils.js

-      sourceMap: options.sourceMap
+      sourceMap: options.sourceMap,
+      plugins: (loader) => [
+        require('autoprefixer')({


'require' is not defined no-undef

houndci-bot · 2019-05-05T20:25:49Z

client/build/utils.js

@@ -25,13 +25,32 @@ exports.cssLoaders = function (options) {
  const postcssLoader = {
    loader: 'postcss-loader',
    options: {
-      sourceMap: options.sourceMap
+      sourceMap: options.sourceMap,
+      plugins: (loader) => [


'loader' is defined but never used no-unused-vars

houndci-bot · 2019-05-05T20:25:49Z

client/build/utils.js

@@ -1,7 +1,7 @@
 'use strict'
 const path = require('path')
 const config = require('../config')
-const ExtractTextPlugin = require('extract-text-webpack-plugin')
+const MiniCssExtractPlugin = require('mini-css-extract-plugin')


'require' is not defined no-undef

I spent a bit more time to update to Webpack 4. I hope it's finished now... References: - vuejs-templates/webpack#1280 - vuejs-templates/webpack#1369

houndci-bot · 2019-05-05T20:32:14Z

db/seeds.rb

+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 2.weeks.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 1.day.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 2.days.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: 1.week.ago, planned_at: 1.day.ago, planned_count: 3 },


Metrics/LineLength: Line is too long. [167/110]

houndci-bot · 2019-05-05T20:32:15Z

db/seeds.rb

+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 1.week.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 2.weeks.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 1.day.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 2.days.ago },


Metrics/LineLength: Line is too long. [152/110]
Style/DateTime: Prefer Date or Time over DateTime.
Rails/TimeZone: Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.to_i, DateTime.now.to_f instead.

houndci-bot · 2019-05-05T20:32:15Z

db/seeds.rb

+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 1.week.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 2.weeks.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 1.day.ago },


Metrics/LineLength: Line is too long. [151/110]
Style/DateTime: Prefer Date or Time over DateTime.
Rails/TimeZone: Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.to_i, DateTime.now.to_f instead.

houndci-bot · 2019-05-05T20:32:15Z

db/seeds.rb

+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 1.week.ago },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 2.weeks.ago },


Metrics/LineLength: Line is too long. [127/110]

houndci-bot · 2019-05-05T20:32:15Z

db/seeds.rb

+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: 1.week.ago },


Metrics/LineLength: Line is too long. [126/110]

houndci-bot · 2019-05-05T20:32:16Z

db/seeds.rb

-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: 1.week.ago, planned_at: 1.day.ago, planned_count: 3 },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },


Metrics/LineLength: Line is too long. [128/110]
Style/DateTime: Prefer Date or Time over DateTime.
Rails/TimeZone: Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.to_i, DateTime.now.to_f instead.

houndci-bot · 2019-05-05T20:32:16Z

db/seeds.rb

-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 2.days.ago },
-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: 1.week.ago, planned_at: 1.day.ago, planned_count: 3 },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },


Metrics/LineLength: Line is too long. [128/110]
Style/DateTime: Prefer Date or Time over DateTime.
Rails/TimeZone: Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.to_i, DateTime.now.to_f instead.

houndci-bot · 2019-05-05T20:32:16Z

db/seeds.rb

-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 1.day.ago },
-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: DateTime.now, planned_at: 2.days.ago },
-  { label: Faker::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'planned', started_at: 1.week.ago, planned_at: 1.day.ago, planned_count: 3 },
+  { label: Faker::TvShows::TwinPeaks.quote, user: user, order: order_sequence.pop, state: 'started', started_at: DateTime.now },


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
Metrics/LineLength: Line is too long. [128/110]
Style/DateTime: Prefer Date or Time over DateTime.
Rails/TimeZone: Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.to_i, DateTime.now.to_f instead.

houndci-bot · 2019-05-05T20:32:17Z

client/build/utils.js

-      sourceMap: options.sourceMap
+      sourceMap: options.sourceMap,
+      plugins: () => [
+        require('autoprefixer')({


'require' is not defined no-undef

houndci-bot · 2019-05-05T20:32:17Z

client/build/utils.js

@@ -1,7 +1,7 @@
 'use strict'
 const path = require('path')
 const config = require('../config')
-const ExtractTextPlugin = require('extract-text-webpack-plugin')
+const MiniCssExtractPlugin = require('mini-css-extract-plugin')


'require' is not defined no-undef

houndci-bot reviewed May 5, 2019

View reviewed changes

marienfressinaud added 2 commits May 5, 2019 22:30

tec: Upgrade to Webpack 4

9e00187

I spent a bit more time to update to Webpack 4. I hope it's finished now... References: - vuejs-templates/webpack#1280 - vuejs-templates/webpack#1369

tec: Fix Faker warning

673ee5a

marienfressinaud force-pushed the tec/upgrade-to-webpack-4 branch from 0fe6f3a to 673ee5a Compare May 5, 2019 20:32

houndci-bot reviewed May 5, 2019

View reviewed changes

marienfressinaud merged commit 673ee5a into master May 5, 2019

marienfressinaud deleted the tec/upgrade-to-webpack-4 branch May 5, 2019 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tec: Upgrade to Webpack 4 #360

tec: Upgrade to Webpack 4 #360

marienfressinaud commented May 5, 2019 •

edited

Loading

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

houndci-bot May 5, 2019

tec: Upgrade to Webpack 4 #360

tec: Upgrade to Webpack 4 #360

Conversation

marienfressinaud commented May 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marienfressinaud commented May 5, 2019 •

edited

Loading