Bugfix: Empty Encoding causes Write Error #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing an empty string for the cURL option CURLOPT_ENCODING causes a write error due to a 0-length write in the underlying libcurl, starting in PHP 8.3.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an empty string for the cURL option
CURLOPT_ENCODINGcauses a write error due to a 0-length write in the underlyinglibcurl, starting in PHP 8.3.7.This has been fixed in cURL and, if I understand correctly, the appropriate fix will be to use the following:
Unfortunately that has not landed in PHP yet and as of PHP 8.3.8 still causes the error.
So for now, I've just restricted auto-detection of encoding to PHP versions below 8.3.7.