RFC7592: set default values for grant_types
and response_types
when updating client
#636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
While implementing RFC7592 endpoint in my code base, I noticed a crash could occur when updating the client if
grant_types
orresponse_types
were not provided:In RFC7591 endpoint, there is a fail-safe fallback to avoid this:
authlib/authlib/oauth2/rfc7591/endpoint.py
Lines 110 to 114 in 5ac4680
authlib/authlib/oauth2/rfc7591/endpoint.py
Lines 121 to 125 in 5ac4680
This PR just backports this behavior to RFC7592. The effect is that, if not provided,
grant_types
andresponse_types
will be set to the default value. From my understanding, this behavior is compliant with the specification: