Fix crash in CRD display #5256
Merged
Fix crash in CRD display #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
ixrock
approved these changes
Apr 25, 2022
jim-docker
approved these changes
Apr 25, 2022
| expect(res).toBe("$.metadata.labels[0].foo[0]"); | ||
| }); | ||
|
|
||
| it("converts ending .. to ..*", () => { |
There was a problem hiding this comment.
Is this the right description?
There was a problem hiding this comment.
No good catch. Will fix in a follow up PR
Merged
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #4999
fixes #5252
fixes #3100