Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some undesirables #5086

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Deprecate some undesirables #5086

merged 2 commits into from
Mar 23, 2022

Conversation

Iku-turso
Copy link
Contributor

No description provided.

@Iku-turso Iku-turso requested a review from a team as a code owner March 23, 2022 16:48
@Iku-turso Iku-turso requested review from jweak and jansav and removed request for a team March 23, 2022 16:48
@Iku-turso
Deprecate a legacy-helper for introducing overly complex and exotic p…
e18cc79 
…attern

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso
Deprecate usages of explicit side effects in production code
ad3b929 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso Iku-turso force-pushed the deprecate-some-undesirables branch from f177219 to ad3b929 Compare March 23, 2022 16:52
@Nokel81 Nokel81 added the chore label Mar 23, 2022
@Nokel81 Nokel81 added this to the 5.5.0 milestone Mar 23, 2022
@Nokel81 Nokel81 merged commit ab4780f into master Mar 23, 2022
@Nokel81 Nokel81 deleted the deprecate-some-undesirables branch March 23, 2022 20:25
@Nokel81 Nokel81 mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

@Nokel81 Nokel81 Nokel81 approved these changes

@jweak jweak Awaiting requested review from jweak jweak is a code owner automatically assigned from lensapp/lens-ide

@jansav jansav Awaiting requested review from jansav jansav is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Iku-turso @Nokel81 @jim-docker