TLS cert per cluster for lens-k8s-proxy #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
previously approved these changes
Mar 23, 2022
jim-docker
reviewed
Mar 24, 2022
There was a problem hiding this comment.
@Nokel81 I think you missed updating src/main/catalog-sources/kubeconfig-sync-manager/kubeconfig-sync-manager.injectable.ts?
ERROR in /Users/jimehrismann/git/lensapp/lens/src/main/catalog-sources/kubeconfig-sync-manager/kubeconfig-sync-manager.injectable.ts
13:49-16:3
[tsl] ERROR in /Users/jimehrismann/git/lensapp/lens/src/main/catalog-sources/kubeconfig-sync-manager/kubeconfig-sync-manager.injectable.ts(13,50)
TS2345: Argument of type '{ directoryForKubeConfigs: string; createCluster: (model: ClusterModel) => Cluster; }' is not assignable to parameter of type 'Dependencies'.
Property 'logger' is missing in type '{ directoryForKubeConfigs: string; createCluster: (model: ClusterModel) => Cluster; }' but required in type 'Dependencies'.
|
|
||
| const certCache: Map<string, selfsigned.SelfSignedCert> = new Map(); | ||
|
|
||
| export function getKubeAuthProxyCertificate(hostname: string, generate: SelfSignedGenerate, useCache = true): selfsigned.SelfSignedCert { |
There was a problem hiding this comment.
fromCache might be better name since the cache is always used, in the sense that it is always updated (line 36) when generated (regardless of the value of useCache)
|
I'm seeing "All checks have passed" but there are only 2 checks?? |
80b8ea8 to
4145428
Compare
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
dbe3178 to
011183a
Compare
Nokel81
approved these changes
Mar 25, 2022
jim-docker
approved these changes
Mar 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5042