Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lens-k8s-proxy to v0.1.5 #4946

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Bump lens-k8s-proxy to v0.1.5 #4946

merged 1 commit into from
Mar 2, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Mar 1, 2022

Signed-off-by: Sebastian Malton sebastian@malton.name

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the dependencies Pull requests that update a dependency file label Mar 1, 2022
@Nokel81 Nokel81 added this to the 5.5.0 milestone Mar 1, 2022
@Nokel81 Nokel81 requested a review from a team as a code owner March 1, 2022 16:24
@Nokel81 Nokel81 requested review from DmitriyNoa and aleksfront and removed request for a team March 1, 2022 16:24
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 requested a review from jim-docker March 1, 2022 16:37
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this when connecting to any cluster:

[0] error:   ▪ [CLUSTER]: Failed to connect to "minikube": StatusCodeError: 404 - "404 page not found\n" +2s
[0] error:   ▪ [LENS-PROXY]: Could not find cluster for upgrade request from url=/ws +2s
[0] error:   ▪ [LENS-PROXY]: Could not find cluster for upgrade request from url=/ws +3s

(and connection fails)

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Mar 2, 2022

Did you clear out the old version from your binaries folder?

@jim-docker
Copy link
Contributor

Did you clear out the old version from your binaries folder?

make dev doesn't do that? I'll do a clean and try again

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Mar 2, 2022

No, all it does it verify that the binary exists and if not downloaded the version specified.

I think we should be able to have it check if the checksums are correct and if not then delete and try again, but that hasn't been implemented yet.

@Nokel81 Nokel81 merged commit d72ebac into master Mar 2, 2022
@Nokel81 Nokel81 deleted the bump-lens-k8s-proxy branch March 2, 2022 22:21
DmitriyNoa pushed a commit that referenced this pull request Mar 3, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
@Nokel81 Nokel81 mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants