Enforce some naming conventions #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
a96005b to
1bcdf03
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…over type - Also export all prop types Signed-off-by: Sebastian Malton <sebastian@malton.name>
059a56c to
a8c5979
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ixrock
approved these changes
Feb 28, 2022
jim-docker
reviewed
Mar 1, 2022
| tabId: TabId; | ||
| submit?: () => Promise<ReactNode | string | void>; | ||
| } | ||
|
|
||
| interface OptionalProps { | ||
| export interface OptionalProps { |
There was a problem hiding this comment.
Suggested change
| export interface OptionalProps { | |
| export interface InfoPanelOptionalProps { |
?
There was a problem hiding this comment.
I'll do that in a follow up PR.
| @@ -32,7 +32,7 @@ enum columnId { | |||
| } | |||
|
|
|||
| @observer | |||
| export class CrdList extends React.Component { | |||
| export class CustomResourceDefinitions extends React.Component { | |||
There was a problem hiding this comment.
is this a breaking change?
There was a problem hiding this comment.
No, because it is not exported
jim-docker
approved these changes
Mar 1, 2022
DmitriyNoa
pushed a commit
that referenced
this pull request
Mar 3, 2022
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interfacedeclarations overtypefor object types.