Replace KubeObjectDetailRegistry with injectable version #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
commented
Jan 5, 2022
| @@ -62,7 +62,8 @@ | |||
| }, | |||
| "moduleNameMapper": { | |||
| "\\.(css|scss)$": "<rootDir>/__mocks__/styleMock.ts", | |||
| "\\.(svg)$": "<rootDir>/__mocks__/imageMock.ts" | |||
| "\\.(svg)$": "<rootDir>/__mocks__/imageMock.ts", | |||
| "^monaco-editor": "<rootDir>/node_modules/monaco-editor" | |||
There was a problem hiding this comment.
This mock is required so that jest won't complain about trying to load it.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jansav
requested changes
Jan 11, 2022
src/renderer/components/kube-object-details/kube-details-items/kube-details.injectable.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
f82e53f to
b0baf4d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Closing in favour of #4717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name