Skip to content

Commit

Permalink
Expose ReactDOM as global object, and ensure in-tree extension to use…
Browse files Browse the repository at this point in the history
… the same instance (#5229)

Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
  • Loading branch information
chenhunghan authored Apr 11, 2022
1 parent 542cbe9 commit c66f9ad
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions extensions/kube-object-event-status/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = [
{
"@k8slens/extensions": "var global.LensExtensions",
"react": "var global.React",
"react-dom": "var global.ReactDOM",
"mobx": "var global.Mobx",
"mobx-react": "var global.MobxReact",
},
Expand Down
1 change: 1 addition & 0 deletions extensions/metrics-cluster-feature/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = [
{
"@k8slens/extensions": "var global.LensExtensions",
"react": "var global.React",
"react-dom": "var global.ReactDOM",
"mobx": "var global.Mobx",
"mobx-react": "var global.MobxReact",
},
Expand Down
1 change: 1 addition & 0 deletions extensions/node-menu/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = [
{
"@k8slens/extensions": "var global.LensExtensions",
"react": "var global.React",
"react-dom": "var global.ReactDOM",
"mobx": "var global.Mobx",
"mobx-react": "var global.MobxReact",
},
Expand Down
1 change: 1 addition & 0 deletions extensions/pod-menu/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = [
{
"@k8slens/extensions": "var global.LensExtensions",
"react": "var global.React",
"react-dom": "var global.ReactDOM",
"mobx": "var global.Mobx",
"mobx-react": "var global.MobxReact",
},
Expand Down
2 changes: 2 additions & 0 deletions src/renderer/bootstrap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import "./components/app.scss";

import React from "react";
import ReactDOM from "react-dom";
import * as Mobx from "mobx";
import * as MobxReact from "mobx-react";
import * as ReactRouter from "react-router";
Expand Down Expand Up @@ -187,6 +188,7 @@ const LensExtensions = {

export {
React,
ReactDOM,
ReactRouter,
ReactRouterDom,
Mobx,
Expand Down

0 comments on commit c66f9ad

Please sign in to comment.