Revert breaking change by making id for select optional (#5164)

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
lensapp · Apr 1, 2022 · 61cff3e · 61cff3e
1 parent 3a26ea7
commit 61cff3e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/renderer/components/select/select.tsx b/src/renderer/components/select/select.tsx
@@ -31,7 +31,7 @@ export interface SelectOption<T = any> {
 }
 
 export interface SelectProps<T = any> extends ReactSelectProps<T, boolean>, CreatableProps<T, boolean> {
-  id: string;
+  id?: string; // Optional only because of Extension API. Required to make Select deterministic in unit tests
   value?: T;
   themeName?: "dark" | "light" | "outlined" | "lens";
   menuClass?: string;
@@ -122,7 +122,7 @@ export class Select extends React.Component<SelectProps> {
 
     const selectProps: Partial<SelectProps> = {
       ...props,
-      inputId,
+      ...(inputId ? { inputId }: {}),
       styles: this.styles,
       value: autoConvertOptions ? this.selectedOption : value,
       options: autoConvertOptions ? this.options : options,