Merge pull request #58 from lenchv/fix/#51-reading-values-on-undefined

fix reading values on undefined

CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+[0.2.0](https://github.com/lenchv/hive-driver/releases/tag/v0.3.0) 2023-09-25
+
+- Upgraded kerberos library
+
+- Added parameter "orientation" to fetch method in order to force using FETCH_NEXT as first operation after initialization schema
+
+- Fixed issue when on pending state the error was thrown
+
+- Fixed issue when in some cases colum was undefined when parsing JsonResult
+
 [0.2.0](https://github.com/lenchv/hive-driver/releases/tag/v0.2.0) 2022-08-20
 
 - Fixed an issue with zero-based column start (Spark Thrift Server, Kyuubi, for example)

lib/result/JsonResult.ts

@@ -46,11 +46,11 @@ export default class JsonResult implements IOperationResult {
     }
 
     private getRows(columns: Array<Column>, descriptors: Array<ColumnDesc>): Array<any> {
-        const columnStartPosition = Math.min(...descriptors.map(d => d.position));
+        const columnStartPosition = Math.max(Math.min(...descriptors.map(d => d.position)), 0);
         return descriptors.reduce((rows, descriptor) => {
             return this.getSchemaValues(
                 descriptor,
-                columns[descriptor.position - columnStartPosition]
+                columns[descriptor.position - columnStartPosition] || {}
             ).reduce((result, value, i) => {
                 if (!result[i]) {
                     result[i] = {};

package.json

@@ -1,6 +1,6 @@
 {
   "name": "hive-driver",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "Driver for connection to Apache Hive via Thrift API.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

tests/unit/result/JsonResult.test.js

@@ -292,4 +292,57 @@ describe('JsonResult', () => {
             "month_interval": null,
         }]);
     });
+
+    it('should check column that starts from 0', () => {
+        const schema = {
+            columns: [
+                getColumnSchema('table.str_0', TCLIService_types.TTypeId.STRING_TYPE, 0),
+                getColumnSchema('table.str', TCLIService_types.TTypeId.STRING_TYPE, 1),
+            ]
+        };
+        const data = [
+            {
+                columns: [{
+                    stringVal: { values: ['a0', 'b0'] }
+                }, {
+                    stringVal: { values: ['a', 'b'] }
+                }]
+            }
+        ];
+
+        const result = new JsonResult(TCLIService_types);
+        result.setOperation({
+            getSchema: () => schema,
+            getData: () => data,
+        });
+
+        expect(result.getValue()).to.be.deep.eq([{
+            "str":"a",
+            "str_0":"a0",
+        }, {
+            "str":"b",
+            "str_0":"b0",
+        }]);
+    });
+
+    it('should not fail if there is no column by descriptor', () => {
+        const schema = {
+            columns: [
+                getColumnSchema('table.str', TCLIService_types.TTypeId.STRING_TYPE, 0),
+            ]
+        };
+        const data = [
+            {
+                columns: []
+            }
+        ];
+
+        const result = new JsonResult(TCLIService_types);
+        result.setOperation({
+            getSchema: () => schema,
+            getData: () => data,
+        });
+
+        expect(result.getValue()).to.be.deep.eq([]);
+    });
 });