Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 cosmetic generator refactor #534

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

techouse
Copy link
Collaborator

I scanned through the generator again and refactored some bits and pieces.

@JEuler let me know your thoughts on this.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d392a1) 94.02% compared to head (7cb384b) 94.02%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #534   +/-   ##
========================================
  Coverage    94.02%   94.02%           
========================================
  Files           10       10           
  Lines          469      469           
========================================
  Hits           441      441           
  Misses          28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JEuler
Copy link
Collaborator

JEuler commented Nov 16, 2023

  old: refer('${Vars.client}.${Vars.baseUrl}'),
  new: refer(Vars.client.toString()).property(Vars.baseUrl.toString()),

It becomes longer without any like, typing benefits, I think. Is that necessary after the refactoring?

@techouse
Copy link
Collaborator Author

The intention here is to swap direct String manipulation with something "safer" 😅

@JEuler
Copy link
Collaborator

JEuler commented Nov 16, 2023

Got it. :)

@techouse techouse merged commit eb3f6c9 into develop Nov 16, 2023
@techouse techouse deleted the chore/refactor-generator branch November 16, 2023 08:57
techouse added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants