Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 Fix CI publish #419

Merged
merged 9 commits into from
May 13, 2023
Merged

💚 Fix CI publish #419

merged 9 commits into from
May 13, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented May 13, 2023 •
edited
Loading

Attempt to fix #418 (comment)

Following the comment here dart-lang/pub#2999 (comment) and not storing the credentials in ~/.pub-cache

CC/ @JEuler

@techouse techouse mentioned this pull request May 13, 2023
Merged
@techouse techouse marked this pull request as draft May 13, 2023 17:14
@techouse techouse marked this pull request as ready for review May 13, 2023 17:49
@techouse
Copy link
Collaborator Author

techouse commented May 13, 2023 •
edited
Loading

@JEuler now I've created a separate dart pub publish --dry-run job which will run on any pull request to the master branch.

On a push to the master branch a dart pub publish --force is run with the correct credentials (I hope).

@techouse techouse marked this pull request as draft May 13, 2023 17:53
@techouse techouse marked this pull request as ready for review May 13, 2023 17:55
@techouse techouse added the ci Continuous Integration label May 13, 2023
@JEuler
Copy link
Collaborator

JEuler commented May 13, 2023

Hooray! Could you probably also create PR for the Master branch?

@techouse
Copy link
Collaborator Author

Hooray! Could you probably also create PR for the Master branch?

Can do.

@techouse techouse merged commit 83f8c25 into lejard-h:develop May 13, 2023
@techouse techouse deleted the fix/fix-publish-github-task branch May 13, 2023 18:03
This was referenced May 13, 2023
Merged
Merged
techouse added a commit that referenced this pull request May 14, 2023
@techouse
🔖 release v6.1.2 (3rd attempt) (#422)
aae0491 
# 6.1.2

* [FIX] #419
* [FIX] #421
* [CHORE] #417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@pingbird pingbird Awaiting requested review from pingbird

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techouse @JEuler