Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmmmmm, should we post a 5.0.1 then for generator? |
|
Potentially, or a Last time I already wanted to use |
|
Ahahaha, could you please update the pubspecs in this PR as it is quickfix. Thank you! |
|
Bumped the version of |
JEuler
approved these changes
Sep 13, 2022
JEuler
added a commit
that referenced
this pull request
Oct 15, 2022
* Fix Header Option Casting (#260) Co-authored-by: Ivan Terekhin <i.terhin@gmail.com> * Fix for #259 (#263) * 4.0.1 fixes (#264) * analyzer dependency upgraded (#296) * fix(generator): fix PartValueFile value not nullable if arg is (#288) (#293) * Chopper generator release 4.0.2 (#297) * fix: fix this.body cast of null value when response body is null (#291) (#292) * Interpolation fixes (#275) * encodeQueryComponent now encodeComponent (#278) * Prevent double call on token refreshment (#276) * Fixes for #309 #308 (#310) * Remove new keyword from interceptors.md (#312) * Analyzer upgrade (#320) Co-authored-by: István Juhos <stewemetal@gmail.com> * Add unnecessary_brace_in_string_interps to lint ignores (#317) * Extend pragma to quiet the linter (#318) Co-authored-by: Ivan Terekhin <i.terhin@gmail.com> * Fix converter getting called twice if using an authenticator with a JsonConverter on the request (#324) * migrate example to nullsafety (#331) * Resolve problem in main_json_serializable example (#328) * Add @FiledMap @PartMap @PartFileMap (#335) Co-authored-by: Meysam Karimi <mysmartapply.it4@gmail.com> * Upgrade of analyzer (#340) * Fix nullable QueryMap fails to compile (#344) * Change return type of decodeJson to FutureOr in order to be able to support compute() (#345) * Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml (#349) * Version bumped for release (#352) * Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement (#354) * [chopper_generator] Update analyzer to ^4.4.0 and code_builde to ^4.3.0 and migrate deprecated code (#358) * Add Makefiles to streamline development (#357) * Add Bug Report Github issue template (#359) * [chopper_generator] Add types to the generated variables (#360) * Provide an example using an Isolate Worker Pool with Squadron (#361) * mapToQuery changes (#364) * Version bumped / changelog update (#367) * Request extends http.BaseRequest (#370) * Exclude null query vars by default and add new @method annotation includeNullQueryVars (#372) * 5.1.0 (dev) (#373) Co-authored-by: Ivan Terekhin <231950+JEuler@users.noreply.github.com> Co-authored-by: Youssef Raafat <youssefraafatnasry@gmail.com> Co-authored-by: luis901101 <luis901101@gmail.com> Co-authored-by: melvspace <ratealt@gmail.com> Co-authored-by: Michal Šrůtek <35694712+michalsrutek@users.noreply.github.com> Co-authored-by: István Juhos <stewemetal@gmail.com> Co-authored-by: Andre <andre.lipke@gmail.com> Co-authored-by: John Wimer <john@wimer.org> Co-authored-by: Max Röhrl <max.roehrl11@gmail.com> Co-authored-by: ipcjs <gipcjs@gmail.com> Co-authored-by: ibadin <exbatek@gmail.com> Co-authored-by: Meysam Karimi <31154534+meysam1717@users.noreply.github.com> Co-authored-by: Meysam Karimi <mysmartapply.it4@gmail.com> Co-authored-by: Klemen Tusar <techouse@gmail.com> Co-authored-by: Klemen Tusar <k.tusar@cmcmarkets.com> Co-authored-by: Ivan Terekhin <231950+JEuler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned previously I had to pin
analyzerto>=4.1.0 <4.3.0.The issue is that
analyzerdeprecatedElement.enclosingElementwhich is being used in chopper_generator and that caused the tests to fail because of a linter warning. 🚨This change inadvertently affects users of
mockito, which has to be pinned to>=5.2.0 <5.3.0to circumvent this small issue.I have now reverted
analyzerback to^4.1.0and silenced those linter errors, however, going forward we should migrate fromElement.enclosingElementtoElement.enclosingElement3as bothElement.enclosingElementandElement.enclosingElement2have been removed fromanalyzer5.0.0.Element.enclosingElement3became available inanalyzer: ^4.4.0. An upgrade to that version will be required in the future.I have put a
TODOcomment into the code precisely for that reason.