Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.3 #305

Merged
merged 13 commits into from
Nov 6, 2021
Merged

Release 4.0.3 #305

merged 13 commits into from
Nov 6, 2021

Conversation

JEuler
Copy link
Collaborator

@JEuler JEuler commented Oct 18, 2021 •
edited
Loading

Co-authored-by: Ivan Terekhin i.terhin@gmail.com
Co-authored-by: Youssef Raafat youssefraafatnasry@gmail.com

@JEuler JEuler requested a review from stewemetal October 18, 2021 14:18
stewemetal
stewemetal reviewed Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@stewemetal stewemetal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion:

I suggest we should keep chopper's and chopper_generator's versions consistent so that we don't confuse our clients, and we can start that now. 🙂

So I advise bumping chopper's version to 4.0.3 too.

Wdyt?

@JEuler
Copy link
Collaborator Author

JEuler commented Oct 26, 2021

Let's bump it :)

@JEuler JEuler changed the title Release 4.0.2 (4.0.3 for Generator) Release 4.0.3 Nov 6, 2021
@JEuler JEuler merged commit d22fe0f into master Nov 6, 2021
@JEuler JEuler deleted the new-release branch November 6, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewemetal stewemetal stewemetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JEuler @stewemetal @yousinix @luis901101 @rIIh