Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #555

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update dependencies #555

merged 1 commit into from
Jun 28, 2022

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Jun 27, 2022

  • Remove google-api-python-client. It doesn't belong here. It was solving problem with protobuf not installed as a transitive dependency of grpcio on some systems (edit: because grpcio doesn't depend on protobuf 😅). Protobuf is used by glocaltokens and now it has explicit dependency to protobuf. This fix only worked by accident, because google-api-python-client transitively depends on protobuf:
google-api-python-client 2.51.0 Google API Client Library for Python
├── google-api-core >=1.31.5,<2.0.0 || >2.3.0,<3.0.0dev
│   ├── protobuf >=3.15.0,<5.0.0dev (circular dependency aborted here)
...
  • Remove zeroconf dependency. We're using it trough homeassistant and want to use the same version as they pin.
  • Bump minimum HA version to 2022.6.0
  • Relax requirement on homeassistant-stubs (add ^). This allows to update both dependencies by running poetry add homeassistant@2022.6.0

@KapJI KapJI requested a review from leikoilja June 27, 2022 10:12
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an awesome cleanup, thanks :)

@leikoilja leikoilja merged commit ee13b38 into leikoilja:master Jun 28, 2022
@KapJI KapJI deleted the rm-google-api branch June 28, 2022 10:49
@KapJI KapJI added the dependencies Pull requests that update a dependency file label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants