Added password length check #506
Conversation
Passwords can't be longer than 100 characters. Added check for this
There was a problem hiding this comment.
This is awesome!
However, i would argue that we should move this validation to glocaltokens package, since it is it's job to take in input parameters and return auth tokens. It is also probably glocaltoken that is freezing out if too long password is given.
We can move this validation to glocaltokens and raise an error during authentication. Here, we can capture the error and show the UI error message. That approach will also allow us to unittest lengthy passwords in glocaltokens. What do you think?
|
@leikoilja I've opened leikoilja/glocaltokens#229 for this |
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
There was a problem hiding this comment.
This is awesome! Thanks @ArnyminerZ for the implementation 💥
Can you please make sure the linting checks passes and merge in when happy with it?
Should fix #430, not yet tested.