Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use permanent link for installs badge #490

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Mar 21, 2022

It'll be redirected to the current endpoint.

It'll be redirected to the current endpoint.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 21, 2022
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's fancy. Did you register an account at runkit and linked it to yourself, @KapJI?

@KapJI
Copy link
Collaborator Author

KapJI commented Mar 21, 2022

I created this endpoint in my account in the first place. It seems we should use the link before the redirect. The link after redirect (with a hash) may change over time while this one should be permanent.

@leikoilja
Copy link
Owner

hmmm, nice! let's try it out then 🚀
Thanks

@leikoilja leikoilja merged commit 5b450d7 into master Mar 21, 2022
@leikoilja leikoilja deleted the installs-badge-fix-2 branch March 21, 2022 13:19
@leikoilja
Copy link
Owner

@KapJI, hmmm, doesn't seem to be working 🤔
image

@KapJI
Copy link
Collaborator Author

KapJI commented Mar 21, 2022

@leikoilja
Copy link
Owner

yeh, the link straight works perfectly fine :) let's give it a little moment to update, will probs be fine in a sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants