Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump glocaltokens to 0.6.3 and adding google-api-python-client dep #472

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

leikoilja
Copy link
Owner

Bumps glocaltokens to 0.6.3 (that fixes the dependency issues)
and add google-api-python-client dep.

@KapJI, maybe you have some good thoughts about it. SInce latest HA is using pip v22.0 which has it's revolver changed we have dep issues (that's the reason why glocaltokens was failing to install to HA). However now that glocaltokens got fixed during the integration installation I have got an unexpected error that google dependency is missing:
image
With the same UI error message Configuration flow could not be loaded: [Object Object] as in #467

A quick search has led me to this, so adding a new dependency google-api-python-client does indeed fix the issue. Could that be right? I don't see how it's fighting together. Or maybe we should move this google-api-python-client dependency to glocaltokens instead?

Closes #467
Closes #470

@leikoilja leikoilja added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 24, 2022
@leikoilja leikoilja requested a review from KapJI February 24, 2022 18:30
@leikoilja leikoilja self-assigned this Feb 24, 2022
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Feb 24, 2022
Copy link
Collaborator

@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the formatting to keep the blame.

Regarding issue with google import, adding dependency sounds right. I'm away from computer and can't check where is the right place to add it. It should be added where it's being used.

@stboch
Copy link

stboch commented Feb 24, 2022

Tested the changes with 2022.3.b1 and it resolved the issues successfully.

@leikoilja leikoilja force-pushed the bump-glocaltokens-0.6.3 branch from 8456599 to 21a96ae Compare February 25, 2022 07:34
@leikoilja leikoilja merged commit 9f203ae into master Feb 25, 2022
@leikoilja leikoilja deleted the bump-glocaltokens-0.6.3 branch February 25, 2022 07:47
@leikoilja
Copy link
Owner Author

Fixed and released in v1.9.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.03.0b0 fails to load Configuration flow could not be loaded: [Object Object]
3 participants