Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new missed state for alarms (#420) #428

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

williamg97
Copy link
Contributor

@williamg97 williamg97 commented Jan 4, 2022

Added status 5 which seems to be missed status. I was able to narrow it down to which of my many devices was causing it and then could see this alarm missed alert when clicking on the alarm icon. Once I'd cleared the following it started to work again.

image

@leikoilja leikoilja linked an issue Jan 5, 2022 that may be closed by this pull request
@leikoilja leikoilja added the bug Something isn't working label Jan 5, 2022
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks, @williamg97 for digging out and finding what the missing status 5 means :) 🚀

I ll let you look though suggested change and then we merge and release a new version 💯

custom_components/google_home/sensor.py Outdated Show resolved Hide resolved
Co-authored-by: Ilja Leiko <leikoilja@users.noreply.github.com>
custom_components/google_home/sensor.py Outdated Show resolved Hide resolved
Co-authored-by: Simon Hansen <67142049+DurgNomis-drol@users.noreply.github.com>
@leikoilja leikoilja dismissed DurgNomis-drol’s stale review January 5, 2022 10:54

Requested changes were accepted and PR cannot be merged without @DurgNomis-drol's approval (testing the feature)

@leikoilja leikoilja merged commit ed88ac0 into leikoilja:master Jan 5, 2022
@leikoilja
Copy link
Owner

Awesome find, @williamg97! Thanks for fixing it 🚀 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 is not a valid GoogleHomeAlarmStatus
3 participants