Use round instead of int #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leikoilja
requested changes
Oct 21, 2021
| @@ -342,7 +342,7 @@ async def update_alarm_volume( | |||
| if JSON_ALARM_VOLUME in response: | |||
| if polling: | |||
| volume_raw = str(response[JSON_ALARM_VOLUME]) | |||
| volume_int = int(float(volume_raw) * 100) | |||
| volume_int = round(float(volume_raw) * 100) | |||
There was a problem hiding this comment.
Since this is volume_int variable and we made Number entity to store the values as integer we would still need to cast it to int here, since round returns float as 88.0 for example :)
Suggested change
| volume_int = round(float(volume_raw) * 100) | |
| volume_int = int(round(volume_raw * 100)) |
There was a problem hiding this comment.
I am not sure i understand what you mean, round() returns an integer if number of digits are not defined.
>>> round(2.555)
3
There was a problem hiding this comment.
haha, what de heck 😄 please just disregard my comment, @DurgNomis-drol, @KapJI
sorry, i got quick reference from here and used the python instance that I had by hand... and guess where the magic is... we still use python 2.7 at work 🤦
haha, you're absolutely right, in python 3 it's integer:
Sorry my fault 😄
leikoilja
approved these changes
Oct 21, 2021
|
@leikoilja Haha 😆 No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359 (comment)
Should we also round the float to less decimals?