Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data collection option #324

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Sep 5, 2021

Data collection is not implemented and I don't see any value in having unused option.

It turns out user reports and logs are sufficient for debugging.

Can be reverted once if at some point we decide to implement it.

@KapJI KapJI added the refactoring Refactoring label Sep 5, 2021
@KapJI KapJI requested a review from leikoilja September 5, 2021 18:28
@github-actions github-actions bot added the translation Translations label Sep 5, 2021
Copy link
Collaborator

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up, I was thinking of the same.
We had a discussion about data collection in #116 but never got around to implement it.
Let's remove this option for now as we might not even use it :)

@KapJI KapJI force-pushed the no-data-collection branch from 7b9819d to 1ae42f0 Compare September 6, 2021 10:31
@KapJI KapJI removed the translation Translations label Sep 6, 2021
@KapJI KapJI merged commit b28a5aa into leikoilja:master Sep 6, 2021
@KapJI KapJI deleted the no-data-collection branch September 6, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants