Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better update handler #323

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Better update handler #323

merged 2 commits into from
Sep 6, 2021

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Sep 5, 2021

  • Instead of reloading the whole integration, just set new update_interval in coordinator.
  • Use new helper functions from config_entry to reduce boilerplate code.
  • Log successful response, can be useful for debugging.
  • Show codes of mypy errors.

@KapJI KapJI added the feature New feature or request label Sep 5, 2021
@KapJI KapJI requested a review from leikoilja September 5, 2021 18:18
leikoilja
leikoilja approved these changes Sep 6, 2021
View reviewed changes
Copy link
Owner

@leikoilja leikoilja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. I m happy someone got at looking for optimisation of HA related logic 💥
Thanks you 💯

custom_components/google_home/api.py Outdated Show resolved Hide resolved
@KapJI KapJI merged commit cd72cde into leikoilja:master Sep 6, 2021
@KapJI KapJI deleted the update-code3 branch September 6, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leikoilja leikoilja leikoilja approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KapJI @leikoilja